Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

last pass of cleanup #18

Merged
merged 2 commits into from
Aug 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .buildkite/pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ steps:
download: "coverage.out"
step: "go_test_libsql"
- docker#v5.11.0:
image: "sonarsource/sonar-scanner-cli:5"
image: "sonarsource/sonar-scanner-cli:11.0"
environment:
- "SONAR_TOKEN"
- "SONAR_HOST_URL=$SONAR_HOST"
Expand All @@ -125,7 +125,7 @@ steps:
download: coverage.out
step: "go_test_libsql"
- docker#v5.11.0:
image: "sonarsource/sonar-scanner-cli:5"
image: "sonarsource/sonar-scanner-cli:11.0"
environment:
- "SONAR_TOKEN"
- "SONAR_HOST_URL=$SONAR_HOST"
Expand Down
3 changes: 3 additions & 0 deletions .github/labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ enhancement:
# Add 'breaking-change' label to any PR where the head branch name starts with `breaking-change` or has a `breaking-change` section in the name
breaking-change:
- head-branch: ["^breaking-change", "breaking-change"]
# Add 'dependencies' label to any PR where the head branch name starts with `dependencies` or has a `dependencies` section in the name
dependencies:
- head-branch: ["^dependencies", "dependencies", "^deps", "deps"]
ci:
- changed-files:
- any-glob-to-any-file: .github/**
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ go.work
# local dev created files
*.db
core
core-cli
openlane-cli
server.crt
server.key
private_key.pem
Expand Down
1 change: 0 additions & 1 deletion .golangci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ issues:
- .buildkite/*
- .github/*
- docker/*
- pkg/utils/totp/testing/*
- internal/ent/generated/*
- jsonschema/templates/*
exclude-files:
Expand Down
9 changes: 5 additions & 4 deletions .goreleaser.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
project_name: core
project_name: openlane
builds:
- env:
- GO111MODULE=on
- CGO_ENABLED=0
binary: openlane
flags:
- -trimpath
- -tags=netgo
Expand Down Expand Up @@ -38,7 +39,7 @@ archives:
format: zip
brews:
- homepage: 'https://github.com/theopenlane/core'
description: 'core is the client CLI for interacting with the OL Core Server'
description: 'openlane is the client CLI for interacting with the openlane server'
directory: Formula
license: 'Apache-2.0'
commit_author:
Expand All @@ -49,7 +50,7 @@ brews:
name: homebrew-tap
token: "{{ .Env.HOMEBREW_TAP_GITHUB_TOKEN }}"
test: |
system "#{bin}/core --help"
system "#{bin}/openlane --help"
source:
enabled: true
changelog:
Expand All @@ -63,7 +64,7 @@ release:
prerelease: auto
github:
owner: theopenlane
name: core
name: openlane
# This section defines how and which artifacts we want to sign for the release.
signs:
- cmd: cosign
Expand Down
6 changes: 0 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,6 @@ We also leverage many secondary technologies in use, including (but not limited
1. [golangci-lint](https://github.com/golangci/golangci-lint) - an annoyingly opinionated linter
1. [buildkite](https://buildkite.com/theopenlane) - our CI system of choice (with github actions providing some intermediary support)

Lastly we're already ourselves using (and plan to support our customers usage in our cloud service) these third party integrations:

1. [turso/libsql](https://github.com/tursodatabase/libsql) - Turso is an edge-hosted, distributed database that's based on libSQL , an open-source and open-contribution fork of SQLite
1. [posthog](https://posthog.com/) - Product analytics
1. [sendgrid](https://sendgrid.com/en-us) - Transactional email send provider

All of these components are bundled into our respective Docker images; for additional information / instructions, see the [contributing guide](.github/CONTRIBUTING.md) in this repository. We're constantly adding and changing things, but have tried to list all the great open source tools and projects we rely on; if you see your project (or one you use) in here and wish to list it, feel free to open a PR!

## Dependencies
Expand Down
6 changes: 3 additions & 3 deletions Taskfile.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ tasks:

go:build-cli:
aliases: [buildcli]
desc: Runs go build for the core cli
desc: Runs go build for the openlane cli
cmds:
- go build -mod=mod -o core-cli ./cmd/cli
- go build -mod=mod -o openlane-cli ./cmd/cli

go:all:
aliases: [go]
Expand Down Expand Up @@ -148,7 +148,7 @@ tasks:
desc: open a new shell to launch server as a dep
cmds:
- rm -f core.db
- rm -f core-cli
- rm -f openlane-cli
- osascript -e 'tell app "Terminal" to do script "cd {{.PWD}} && task run-dev"'
vars:
PWD:
Expand Down
1 change: 0 additions & 1 deletion atlas.hcl
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
variable "cloud_token" {
type = string
default = getenv("ATLAS_CLOUD_TOKEN")
}

Expand Down
2 changes: 1 addition & 1 deletion cmd/serve.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func serve(ctx context.Context) error {
serveropts.WithSessionManager(redisClient),
)

// Setup Geodetic client
// Setup DBx client
if so.Config.Settings.DBx.Enabled {
gc := so.Config.Settings.DBx.NewDefaultClient()

Expand Down
2 changes: 2 additions & 0 deletions gen_schema.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ func main() {
if err != nil {
log.Fatal(err)
}

defer f.Close()

fmtr := formatter.NewFormatter(f)

fmtr.FormatSchema(schema)
Expand Down
Loading