Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User messages sent after a frontend locale change keep the old locale #168

Closed
Fabilin opened this issue Jul 15, 2024 · 0 comments
Closed

User messages sent after a frontend locale change keep the old locale #168

Fabilin opened this issue Jul 15, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Fabilin
Copy link
Member

Fabilin commented Jul 15, 2024 •
edited
Loading

#152 added a new locale parameter to useTock, which can change at any time after page load. However the sendMessage method returned by this hook does not account for changes to said parameter, meaning it is never updated after the first call to useTock.
@Fabilin Fabilin added the bug Something isn't working label Jul 15, 2024
Fabilin added a commit to Fabilin/tock-react-kit that referenced this issue Jul 15, 2024
@Fabilin
fix theopenconversationkit#168: add missing locale dependency to send…
eee59a1 
…Message callback
@Fabilin Fabilin closed this as completed in 91d6309 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Fabilin