-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fchk to FCIDUMP (with gbasis) #362
Comments
Can you be more specific about the change you'd propose? I think, from the way you explain it, the issue is a You should also feel free to make a pull request with the documentation change you're suggesting. It's always most useful for the users to suggest the changes that would have made their lives easier; as developers we're often too deep in the weeds to understand how outsiders see it. |
A warning does not seem to be the right solution when IOData and GBasis behave as documented. Maybe a worked-out example in GBasis that shows how to write an FCIDUMP file could help? It would make sense to add a note to the FCIDUMP docstring to explain that the internal representation in IOData and FCIDUMP differ, and that the numbers are rearranged upon loading and dumping. I'll make a PR with a suggestion to make this a bit more concrete. One could go further and add some metadata in the |
I think a worked example in |
Sure, that’s what I had in mind.
Again, this was not meant as a complaint at all!
…________________________________
From: Paul W. Ayers ***@***.***>
Sent: Saturday, July 6, 2024 1:31:14 PM
To: theochem/iodata ***@***.***>
Cc: Paul Andrew Johnson ***@***.***>; Mention ***@***.***>
Subject: Re: [theochem/iodata] fchk to FCIDUMP (with gbasis) (Issue #362)
I think a worked example in gbasis is sensible. @paulandrewjohnson<https://github.com/paulandrewjohnson> , I'd invite you to even use your own experience to provide such an example, then make a pull request in gbasis.
—
Reply to this email directly, view it on GitHub<#362 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AE7SKZPC3ZCFY6UYTUOWJW3ZLASWFAVCNFSM6AAAAABKNO2HA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRHAZDMOBUGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
No worries. We appreciate that you bring this up. It is always a bit of a puzzle where and how to improve things. |
I was able to read an fchk with IOdata, use gbasis to compute integrals, then write to an FCIDUMP with IOdata.
Please add a warning to the gbasis documentation examples: IOdata assumes integrals are stored internally in physicists' notation, hence transposes to chemists' notation upon dumping an FCIDUMP. Hence, one should not compute the 2 electron integrals with notation='chemist'.
Everything makes sense, and I am sorry for bringing this up. It would help.
The text was updated successfully, but these errors were encountered: