Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of the dist folder #54

Open
CirXe0N opened this issue Nov 20, 2020 · 1 comment
Open

Removal of the dist folder #54

CirXe0N opened this issue Nov 20, 2020 · 1 comment

Comments

@CirXe0N
Copy link
Contributor

CirXe0N commented Nov 20, 2020

Is there a specific reason why we need this folder?

If the reason is PyPi, we can just update the setup.py to download directly from Github.
(https://github.com/thenewboston-developers/thenewboston-python-client/archive/master.zip)

Later on we can create releases within Github and use those direct download links. (https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/managing-releases-in-a-repository)

@shahraizali
Copy link
Contributor

Right now it's the way it is for the sake of simplicity Ideally you are right about the Github releases and the connection of setup to master should be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants