Replies: 3 comments 2 replies
-
Hey, it's nice idea, I think about this every time I work with the library, but I thought I'd bring it up when all the components are ready. |
Beta Was this translation helpful? Give feedback.
-
Thanks everyone for contributing! Let's go with |
Beta Was this translation helpful? Give feedback.
-
Here is PR #202 with proposed changes to our linting rules. Would be great if you could test it and comment (approve? 🙈) to give me 🟢 light to continue on linting and refactoring component names. |
Beta Was this translation helpful? Give feedback.
-
Hey :)
Since we're still at the very early stage of development I would like to propose standardization of component names according to few rules from the official Vue's Style Guide:
Essential:
Strongly Recommended:
Button
stops working when converted to kebab-casebutton
which then is just regular HTML elementButton
,Checkbox
,Table
,Textarea
,TheCard
component... first of all it shouldn't be prefixed like that as it can be used multiple times, secondly it breaks overall naming pattern as it's the only exception like thatAbove rules are available as eslint rules... currently we have enabled
'plugin:vue/essential'
with explicitly removed'vue/multi-word-component-names': 'off',
I would recommend changing that at least to
"plugin:vue/vue3-strongly-recommended"
or in the best scenario to"plugin:vue/vue3-recommended"
as it's the strictest and apart from following best practices it will lead to minimal code differenced between contributors.A lot of the above problems could be solved by adding some arbitrary "package prefix" like most other UI Libraries do:
Button component examples:
Ant Design Vue:
<a-buttton>
Ionic Vue:
<ion-button>
NaiveUI:
<n-button>
Vuetify:
<v-btn>
I would suggest adding prefix to all components... something like
f-
(orfb-
/fbv-
but the easier the better)Beta Was this translation helpful? Give feedback.
All reactions