Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Response Params need a "Revision" XML tag #7

Open
prabhathn opened this issue Oct 17, 2019 · 2 comments
Open

Optional Response Params need a "Revision" XML tag #7

prabhathn opened this issue Oct 17, 2019 · 2 comments

Comments

@prabhathn
Copy link

Propose adding this at the following line: https://github.com/thelinuxkid/pyusps/blob/master/pyusps/address_information.py#L133

    # Documentation refers to this as "Version" - it is an option to return all optional data as well
    version_el = etree.Element('Revision')
    version_el.text = '1'
    root.append(version_el)

Without this code, the USPS API only returns the Address, City, State, Zip. By including this Revision tag, we get all the optional params as well.

@thelinuxkid
Copy link
Owner

Thanks. Can you make a PR please?

@prabhathn
Copy link
Author

Sure! Here you go: #8

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants