New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RuntimeException or GrokException in Match #89

Open

fbacchella opened this issue Apr 14, 2018 · 1 comment

Contributor

fbacchella commented Apr 14, 2018

java-grok/src/main/java/io/krakens/grok/api/Match.java

Line 146 in 95dc26e

throw new RuntimeException(

I'm not a big fan of the too generic RuntimeException. It make error dispatch using smart try ... catch difficult. Why not a GrokException here ?

Member

anthonycorbacho commented Apr 16, 2018

+1 for using GrokException

fbacchella mentioned this issue

Match.capture nows throws a GrokException #92

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment