Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test improvement: observe window.location #12

Closed
thejohnhoffer opened this issue Dec 22, 2021 · 0 comments · Fixed by #13
Closed

Test improvement: observe window.location #12

thejohnhoffer opened this issue Dec 22, 2021 · 0 comments · Fixed by #13
Labels
tests Improvements to tests

Comments

@thejohnhoffer
Copy link
Owner

Just like history Issue #918, the tests in use-hash-history should actually observe the effects of our changes on the window.location.
@thejohnhoffer thejohnhoffer added the tests Improvements to tests label Dec 22, 2021
@thejohnhoffer thejohnhoffer mentioned this issue Dec 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Improvements to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

911 thejohnhoffer/use-hash-history
1 participant
@thejohnhoffer