Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility of ep.pp.explicit_impute with different datatypes #848

Open
2 tasks
eroell opened this issue Jan 8, 2025 · 1 comment · May be fixed by #865
Open
2 tasks

Compatibility of ep.pp.explicit_impute with different datatypes #848

eroell opened this issue Jan 8, 2025 · 1 comment · May be fixed by #865
Assignees
Labels
enhancement New feature or request

Comments

@eroell
Copy link
Collaborator

eroell commented Jan 8, 2025

Description of feature

Follow the template workflow of #835:

  • introduce singledispatch to check for allowed data types, or raise an error if others are encountered
  • adapt the tests to check these data types

Create underscore private function for each datatype, and keep the adata object as primary

@eroell eroell added the enhancement New feature or request label Jan 8, 2025
@aGuyLearning
Copy link
Collaborator

A problem arrises when testing a dask array. the impute method works, it just fails during the quality control step of _warn_imputation_threshold. the qc_metrics function calls _var_qc_metrics function, where it fails on an indexing issue. Could also be an issue with #851, once more datatypes should be supported

@aGuyLearning aGuyLearning linked a pull request Feb 5, 2025 that will close this issue
5 tasks
@aGuyLearning aGuyLearning linked a pull request Feb 5, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants