Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

odd card styles (missing react social icon) #16

Closed
thescientist13 opened this issue Mar 19, 2018 · 3 comments
Closed

odd card styles (missing react social icon) #16

thescientist13 opened this issue Mar 19, 2018 · 3 comments
Assignees
@thescientist13
Labels
bug Something isn't working fast-follow Not top priority, but should be done when possible
Milestone
Greenwood Upgrade

Comments

@thescientist13
Copy link
Member

thescientist13 commented Mar 19, 2018 •
edited
Loading

The 4th in each series of <Card> elements is wonky. VIsit the about page to reproduce

Presentations

The whole thing is shifted to the left
screen shot 2018-03-19 at 12 24 51 pm

**Update: fixed in #20 ** 🎉

Articles

The icon is missing
screen shot 2018-03-19 at 12 24 56 pm

Seems to be <SocialIcon> doesn't know what to do with a URL like this
https://techblog.kenzan.com/managing-open-source-project-github/
@thescientist13 thescientist13 added the bug Something isn't working label Mar 19, 2018
@thescientist13 thescientist13 self-assigned this Mar 19, 2018
@thescientist13 thescientist13 mentioned this issue Mar 19, 2018
Merged
3 tasks
@thescientist13 thescientist13 mentioned this issue Mar 19, 2018
Merged
@thescientist13 thescientist13 added the fast-follow Not top priority, but should be done when possible label Mar 19, 2018
@thescientist13
Copy link
Member Author

Hmmm.... looks like the repo doesn't allow issues?
https://www.npmjs.com/package/react-social-icons
https://github.com/AVVS/react-social-icons

@thescientist13 thescientist13 changed the title odd card styles odd card styles (missing react social icon) Apr 27, 2018
@thescientist13
Copy link
Member Author

thescientist13 commented May 4, 2018 •
edited
Loading

So after reviewing the source a bit, the behavior I see is expected given the current conditions. <SocialIcon> can't determine the network based on the URL hence it will be blank. Not sure why there is no default instead though? 🤔

Otherwise, will need to pass network manually for this particular use case.

@thescientist13
Copy link
Member Author

this will get fixed as part of #96 since we will just create our own custom <SocialIcon> component

@thescientist13 thescientist13 added this to the Greenwood Upgrade milestone Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
bug Something isn't working fast-follow Not top priority, but should be done when possible
Projects
None yet
Milestone
Greenwood Upgrade
Development

No branches or pull requests
1 participant
@thescientist13