Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public folder is being added to new Quire projects #888

Open
1 task done
Erin-Cecele opened this issue Dec 12, 2023 · 2 comments
Open
1 task done

Public folder is being added to new Quire projects #888

Erin-Cecele opened this issue Dec 12, 2023 · 2 comments
Assignees
Labels
status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues.

Comments

@Erin-Cecele
Copy link
Collaborator

Before proceeding, make sure there isn’t an existing issue for this bug.

  • I have searched the existing issues and determined this is a new bug.

Expected Behavior

Still determining if this is the expected behavior.

Actual Behavior

Currently, when starting a new project with quire new a public directory is added to the project, but I don't know where it's coming from or why.

Which brings up some questions:

  • Should public folder be gitignored?
  • There are almost identical .gitignore files in the starter and in the core repo
  • Should we be deleting the public directory after _site is built?

Steps to Reproduce

  1. Start a new project
  2. Locate the public directory
  3. Run quire build and note that the public folder is duplicated in the _site folder
  4. Check GH Desktop to see all the public files that are queued up to be committed to the project (1000+)1.0.

Version Numbers

quire 1.0.0-rc 10

Web Browser

Chrome

Relevant Terminal/Shell Output

No response

Supporting Information

No response

@Erin-Cecele Erin-Cecele added the status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues. label Dec 12, 2023
@Erin-Cecele Erin-Cecele self-assigned this Dec 12, 2023
@Erin-Cecele Erin-Cecele changed the title Public folder is being added to new Quire projects” Public folder is being added to new Quire projects Dec 12, 2023
@Erin-Cecele
Copy link
Collaborator Author

Erin-Cecele commented Aug 7, 2024

@geealbers When I started a new project with CLI-rc.14 and 11ty-rc.17, I did not see the public folder being generated in my new project. I wonder if this issue was fixed and can be closed??

Screen Shot 2024-08-07 at 2 40 16 PM

@Erin-Cecele
Copy link
Collaborator Author

Also, noting here that the public folder is no longer duplicated in the _site folder

Screen Shot 2024-08-07 at 4 51 02 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues.
Projects
None yet
Development

No branches or pull requests

1 participant