Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when multiple objects are included on a catalogue page, only the last listed appears in the online view #876

Open
1 task done
KJustement opened this issue Nov 7, 2023 · 5 comments
Assignees
Labels
enhancement Proposed new feature. There are no guarantees a suggested enhancement will be included in Quire. status: test needed tested needed to confirm the issue and determine how to proceed

Comments

@KJustement
Copy link

Before proceeding, make sure there isn’t an existing issue for this bug.

  • I have searched the existing issues and determined this is a new bug.

Expected Behavior

A second object id (from object.yaml page) was added to a single catalogue page. It was expected that the additional object id would populate the catalogue page with that object image and data after the first object once the project was previewed/built.

Actual Behavior

Instead, once the project was built, the online version only showed the image for the second, new object id entered in the catalogue page. All text data associated with both object ids appeared online. In the catalogue grid view, that single catalogue page did show the first, original object id image as a thumbnail, however.

In the pdf format, however, almost everything operated as expected. In the grid view, the single catalogue page showed the first, original object id image as a thumbnail. The individual catalogue page showed the two images for both object ids in the correct order, and the relevant text data associated with both object ids populated the catalogue page. However, the title for the multi-object catalogue page was only populated with the data from the first, original object id (PDF attached).
pagedjs.pdf
Please see pages 5–8, with special attention to "Cat. 1"

Steps to Reproduce

Working from the Quire tutorial test project:

  1. Find a new object to utilize for the new catalogue entry. I went to the Getty's website and found an additional Dorothea Lange photograph.
  2. Download that image and add it to the _assets/figures/images folder as either a .jpg or .png
  3. In VSC, go to the _data/objects.yaml file and create a new object entry (with object id) using the object information from the Getty's website, following the format for the preexisting object entries.
  4. Go to the catalogue folder in VSC, create a new .md file (I labeled mine "3.md", given that there were already two catalogue entries).
  5. Following the format of the existing catalogue .md files, populate your new catalogue page.
  6. Go to the first, original catalogue page (in this case, "1.md"). Where you see the object id associated with this first catalogue page, enter the new object id from the objects.yaml file in the line below.
  7. Preview the project.
  8. Build the project and create a pdf.

Version Numbers

The "quire info --debug" command did not work in my project directory
Terminal Saved Output.txt
Screenshot 2023-11-07 at 9 08 29 AM

Web Browser

Safari, version 16.6

Relevant Terminal/Shell Output

No response

Supporting Information

No response

@KJustement KJustement added the status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues. label Nov 7, 2023
@mphstudios mphstudios added the quire-11ty This is an issue with the quire-11ty package label Nov 15, 2023
@Erin-Cecele
Copy link
Collaborator

Erin-Cecele commented Nov 30, 2023

@KJustement the reason quire info --debug did not work is because you are using Quire v0. Are you testing this for a new Getty Quire project? Or an older one? Running the nvm command will help you switch between versions (nvm use 18 brings me to 1.0.0-rc.10 which is v1.)

@Erin-Cecele
Copy link
Collaborator

@mphstudios I'm removing the quire-11ty tag until we can confirm this is an issue in v1.

@Erin-Cecele Erin-Cecele removed the quire-11ty This is an issue with the quire-11ty package label Nov 30, 2023
@KJustement
Copy link
Author

@Erin-Cecele sorry, I realized that I am set to Quire v0 as default and ran the commands with that. However, I double checked the project settings and it is built from Quire v1. Here is the new quire info --debug result:
Screenshot 2023-12-04 at 1 49 42 PM

@Erin-Cecele Erin-Cecele added the quire-11ty This is an issue with the quire-11ty package label Dec 5, 2023
@Erin-Cecele
Copy link
Collaborator

Got it! Thanks for the update @KJustement!

@Erin-Cecele Erin-Cecele added enhancement Proposed new feature. There are no guarantees a suggested enhancement will be included in Quire. status: test needed tested needed to confirm the issue and determine how to proceed and removed status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues. labels Dec 6, 2023
@Erin-Cecele
Copy link
Collaborator

Erin-Cecele commented Dec 19, 2023

Tested by adding cat-3 to the project. Added a new image and then added new entries to the figures.yaml file and the objects.yaml file. Then added the new object id to both cat-1 and cat-2.

  • When the new id cat-3 was added to the cat-1 entry, only the cat-3 image shows.
  • The tombstone information appears for both objects, but only the title of cat-1 appears. The spacing also looks off.
Screen Shot 2023-12-19 at 9 02 26 AM
  • When cat-3 was added to cat-2 (an entry which has three images), the new object id overlays with the original image.
Screen Shot 2023-12-19 at 9 04 45 AM
  • The forward and backward buttons in the image lightbox do not work.
  • As Kate mentioned, the catalogue menu page only shows the original object entry
Screen Shot 2023-12-19 at 9 05 30 AM
  • the sidebar TOC also only lists the original object entry

@Erin-Cecele Erin-Cecele removed the quire-11ty This is an issue with the quire-11ty package label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Proposed new feature. There are no guarantees a suggested enhancement will be included in Quire. status: test needed tested needed to confirm the issue and determine how to proceed
Projects
None yet
Development

No branches or pull requests

3 participants