Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2 Release a new version of theforeman-rubocop #13

Open
3 tasks done
archanaserver opened this issue May 31, 2024 · 4 comments
Open
3 tasks done

#2 Release a new version of theforeman-rubocop #13

archanaserver opened this issue May 31, 2024 · 4 comments

Comments

@archanaserver
Copy link
Contributor Author

@ekohl is there anything else that need to be done here?

@ekohl
Copy link
Member

ekohl commented Aug 29, 2024

We need to update all the RuboCop version to the latest. There are new versions released by now (see open PRs).

And we don't need this dependency anymore and we should drop it

spec.add_dependency 'rubocop-checkstyle_formatter', '~> 0.6.0'

@ekohl
Copy link
Member

ekohl commented Aug 29, 2024

Another thing I noticed while running RuboCop on Foreman is that I saw:

The following RuboCop extension libraries are installed but not loaded in config:
  * rubocop-capybara
  * rubocop-graphql

You can opt out of this message by adding the following to your config (see https://docs.rubocop.org/rubocop/extensions.html#extension-suggestions for more options):
  AllCops:
    SuggestExtensions: false

I think we should include those in rules/rails.yml as enabled extensions.

@archanaserver
Copy link
Contributor Author

@ekohl raised PRs to fix it, #24 #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants