-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Longer running requests #12
Comments
The problem seems to be that server.close() kills a running request. In the consequence of that the callback of server.close() is called although the current request has not ended properly. Any ideas? |
Just to make it clear: That what you stated in your article
is not what I experience. When calling server.close() while a request is in process that request is terminated and lost. Did I do or understand something wrong? |
@jochenonline The quote is describing the behavior of native server.close(). The purpose of this library is to terminate those connections and work around the native behavior. |
I am speaking about the server.close() within the library. The library itself takes care of the non idle connections, but server.close() itself does not. And because the library calls server.close() a running request is terminated anyway. |
@jochenonline From the official docs (https://nodejs.org/api/net.html#net_server_close_callback):
This aligns what I've only ever seen. |
When I process a longer running request (aboz 2 seconds). The request will be destroyed before termination. Is there any chance to have those requests processed befor the server is destroyed?
The text was updated successfully, but these errors were encountered: