Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of format on [s]printf #3

Open
trejjam opened this issue Nov 1, 2018 · 1 comment
Open

Validation of format on [s]printf #3

trejjam opened this issue Nov 1, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@trejjam
Copy link

trejjam commented Nov 1, 2018

Hi, first thank for a great idea with the /safe package.
I found out that using functions [s]printf from Safe namespace make PHPStan\Rules\Functions\PrintfParametersRule not working (it does not validate a number of parameters anymore)

@moufmouf moufmouf added the enhancement New feature or request label Nov 6, 2018
@moufmouf
Copy link
Member

moufmouf commented Nov 6, 2018

Indeed, since the function used is Safe\sprintf instead of sprintf alone, the rule is not triggered anymore.

I would need to reimplement the rule for Safe\sprintf in the Safe PHPStan extension.
I don't know if this is easy to do yet. I'll keep the issue open until I have some time to figure that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants