Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does "margin" actually work? #4

Closed
maxgmer opened this issue Sep 13, 2024 · 2 comments
Closed

Does "margin" actually work? #4

maxgmer opened this issue Sep 13, 2024 · 2 comments

Comments

@maxgmer
Copy link

maxgmer commented Sep 13, 2024

I have bitcoin-qr element with width="160", height="160".
When I set margin="16", it looks 100% the same as margin="1".

Is it a bug?

@thebrandonlucas
Copy link
Owner

thebrandonlucas commented Sep 14, 2024

Hi @maxgmer! I think I remember running into something like this; and unfortunately it seems like it may be a problem on the underlying QR code library (margin is a prop of that library that we just pass down).

A workaround, noted here, would be to just wrap the QR code in a div, and set the padding as desired and background-color: white.

@maxgmer
Copy link
Author

maxgmer commented Sep 14, 2024

Hi @maxgmer! I think I remember running into something like this; and unfortunately it seems like it may be a problem on the underlying QR code library (margin is a prop of that library that we just pass down).

A workaround, noted here, would be to just wrap the QR code in a div, and set the padding as desired and background-color: white.

I see, thanks for the tip. Will try your suggestion.

@maxgmer maxgmer closed this as completed Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants