Skip to content

Commit

Permalink
wallet: remove unused SignatureData instances in spkm's FillPSBT
Browse files Browse the repository at this point in the history
…methods

These are filled with signature data from a PSBT input, but not used anywhere
after, hence they can be removed.
  • Loading branch information
theStack committed Jan 22, 2024
1 parent 651fb03 commit e2ad343
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/wallet/scriptpubkeyman.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -652,8 +652,6 @@ TransactionError LegacyScriptPubKeyMan::FillPSBT(PartiallySignedTransaction& psb
// There's no UTXO so we can just skip this now
continue;
}
SignatureData sigdata;
input.FillSignatureData(sigdata);
SignPSBTInput(HidingSigningProvider(this, !sign, !bip32derivs), psbtx, i, &txdata, sighash_type, nullptr, finalize);

bool signed_one = PSBTInputSigned(input);
Expand Down Expand Up @@ -2520,8 +2518,6 @@ TransactionError DescriptorScriptPubKeyMan::FillPSBT(PartiallySignedTransaction&
// There's no UTXO so we can just skip this now
continue;
}
SignatureData sigdata;
input.FillSignatureData(sigdata);

std::unique_ptr<FlatSigningProvider> keys = std::make_unique<FlatSigningProvider>();
std::unique_ptr<FlatSigningProvider> script_keys = GetSigningProvider(script, /*include_private=*/sign);
Expand Down

0 comments on commit e2ad343

Please sign in to comment.