From 9ec2c53701a391629b55aeb2804e8060d2c453a4 Mon Sep 17 00:00:00 2001 From: Sebastian Falbesoner Date: Mon, 1 Jul 2024 20:49:18 +0200 Subject: [PATCH] Revert "test: p2p: check that connecting to ourself leads to disconnect" This reverts commit 5d2fb14bafe4e80c0a482d99e5ebde07c477f000 and adds a TODO to add it later again once the race condition is fixed. --- test/functional/p2p_handshake.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/test/functional/p2p_handshake.py b/test/functional/p2p_handshake.py index 673322ab10c52..21959ae522ebe 100755 --- a/test/functional/p2p_handshake.py +++ b/test/functional/p2p_handshake.py @@ -17,7 +17,6 @@ NODE_WITNESS, ) from test_framework.p2p import P2PInterface -from test_framework.util import p2p_port # Desirable service flags for outbound non-pruned and pruned peers. Note that @@ -89,11 +88,9 @@ def run_test(self): with node.assert_debug_log([f"feeler connection completed"]): self.add_outbound_connection(node, "feeler", NODE_NONE, wait_for_disconnect=True) - self.log.info("Check that connecting to ourself leads to immediate disconnect") - with node.assert_debug_log(["connected to self", "disconnecting"]): - node_listen_addr = f"127.0.0.1:{p2p_port(0)}" - node.addconnection(node_listen_addr, "outbound-full-relay", self.options.v2transport) - self.wait_until(lambda: len(node.getpeerinfo()) == 0) + # TODO: re-add test introduced in commit 5d2fb14bafe4e80c0a482d99e5ebde07c477f000 + # ("test: p2p: check that connecting to ourself leads to disconnect") once + # the race condition causing issue #30368 is fixed if __name__ == '__main__':