Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework contribution section #350

Merged
merged 28 commits into from
Aug 12, 2024
Merged

Conversation

CaptainSifff
Copy link
Collaborator

Oh well, I looked into the Credit system again, and I only thought....
Well, how does this fit to us?
So I wrote a generic text to tick that box, and went on to detail those parts that I could remember, which you have contributed over the past years.
Feel free to raise your opinions.

I also accept private E-Mail, if I took a wrong direction somewhere....

Now comes the pleasure of finding all your github usernames ....

@CaptainSifff
Copy link
Collaborator Author

Pinging @sdruskat , @tobyhodges @annalenalamprecht , @HeidiSeibold , @hvwaldow , @samumantha
As I found out there's a limit of 15 reviewers on github....

@jngrad
Copy link
Collaborator

jngrad commented Aug 9, 2024

I predict there will be a lot of small changes during review. In order to reduce notifications, we could apply suggested changes in batches, i.e. 1 commit for multiple review comments. 😉 This option is only visible in the Changes tab, afaik.

@CaptainSifff
Copy link
Collaborator Author

the spell-checker will be made happy by the PR of @jcohen02 .

Copy link
Collaborator

@mhagdorn mhagdorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expanded shortened verbs

@annalenalamprecht
Copy link
Contributor

annalenalamprecht commented Aug 12, 2024

I cannot find it back right now, but @MakisH pointed out earlier that "helped us" (and similar wording) sounds a bit odd when mentioning people who are also on the list of authors. Simply removing the "us" from these sentences would solve the issue.

Edit: Seeing now that @knarrff was just making changes in this direction. Thanks!!

@jpthiele jpthiele changed the title New acknowledgements Rework contribution section Aug 12, 2024
Florian Goth and others added 2 commits August 12, 2024 10:30
CaptainSifff and others added 5 commits August 12, 2024 10:36
Co-authored-by: Jan Philipp Thiele <[email protected]>
Co-authored-by: Gerasimos Chourdakis <[email protected]>
Co-authored-by: Magnus Hagdorn <[email protected]>
This was referenced Aug 12, 2024
@CaptainSifff
Copy link
Collaborator Author

I'm beginning the publication process, thereby closing this box as of now.

@CaptainSifff CaptainSifff merged commit 391af17 into main Aug 12, 2024
5 checks passed
@sdruskat
Copy link
Contributor

sdruskat commented Aug 12, 2024 via email

@jngrad jngrad deleted the 333-iterate-the-credit-section branch August 13, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Iterate the CRediT section
9 participants