-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework contribution section #350
Conversation
Pinging @sdruskat , @tobyhodges @annalenalamprecht , @HeidiSeibold , @hvwaldow , @samumantha |
I predict there will be a lot of small changes during review. In order to reduce notifications, we could apply suggested changes in batches, i.e. 1 commit for multiple review comments. 😉 This option is only visible in the Changes tab, afaik. |
the spell-checker will be made happy by the PR of @jcohen02 . |
Co-authored-by: Jean-Noël Grad <[email protected]>
Co-authored-by: Jean-Noël Grad <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expanded shortened verbs
Co-authored-by: Magnus Hagdorn <[email protected]>
I cannot find it back right now, but @MakisH pointed out earlier that "helped us" (and similar wording) sounds a bit odd when mentioning people who are also on the list of authors. Simply removing the "us" from these sentences would solve the issue. Edit: Seeing now that @knarrff was just making changes in this direction. Thanks!! |
Co-authored-by: Frank Löffler <[email protected]>
Co-authored-by: Gerasimos Chourdakis <[email protected]>
Co-authored-by: Jan Philipp Thiele <[email protected]> Co-authored-by: Gerasimos Chourdakis <[email protected]>
Co-authored-by: Magnus Hagdorn <[email protected]>
I'm beginning the publication process, thereby closing this box as of now. |
Thanks for the ping, I‘ll get to review this week (before Friday).
|
Oh well, I looked into the Credit system again, and I only thought....
Well, how does this fit to us?
So I wrote a generic text to tick that box, and went on to detail those parts that I could remember, which you have contributed over the past years.
Feel free to raise your opinions.
I also accept private E-Mail, if I took a wrong direction somewhere....
Now comes the pleasure of finding all your github usernames ....