Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yvgrossmann feedback #349
Yvgrossmann feedback #349
Changes from 6 commits
56e7d63
ebb7ecf
561df37
9187e15
748fff8
c6c5ff4
7fc3c81
71c04bb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I understand the difference between:
Doesn't
within
implyduring
, andduring
implywithin
, given that we are only talking about the project and not any external system?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My best guess would be that
during
refers to the people in the project processing the metadata mentally whilewithin
means that the software itself makes use of the metadata. But I agree that it is something that makes one stumble when reading.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it is somewhat redundant. However, I wanted to emphasise that using metadata during the project to help direct the project is a real benefit. Typically, the common view is that metadata is collected for follow on projects or other users of the project. The metadata is then like a tombstone: here lies.... RIP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True.. But would we need both during and within then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I missed the last bit, edify the project. I don't like this phrase, it has religious connotations to me. I prefer the original inform the decision making as that's more neutral.