Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yvgrossmann feedback #349

Merged
merged 8 commits into from
Aug 11, 2024
Merged

Yvgrossmann feedback #349

merged 8 commits into from
Aug 11, 2024

Conversation

CaptainSifff
Copy link
Collaborator

I did it!

@CaptainSifff CaptainSifff self-assigned this Aug 9, 2024
@CaptainSifff
Copy link
Collaborator Author

@ljgarcia What's your idea, do you feel that your paper: https://zenodo.org/records/10374839 makes sense here? From looking over it, It felt more like a report of a productive hackathon, then a collection of current best practice. Also pinging your colleague @yvgrossmann .

@CaptainSifff CaptainSifff linked an issue Aug 9, 2024 that may be closed by this pull request
Copy link
Collaborator

@jcohen02 jcohen02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made one minor suggestion but happy to approve nonetheless, this looks fine to me.

competencies.md Outdated
Comment on lines 823 to 824
Metadata can also be used
actively during, within, and after a research project, to edify the decision-making
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I understand the difference between:

  • used during a project
  • used within a project

Doesn't within imply during, and during imply within, given that we are only talking about the project and not any external system?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My best guess would be that during refers to the people in the project processing the metadata mentally while within means that the software itself makes use of the metadata. But I agree that it is something that makes one stumble when reading.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it is somewhat redundant. However, I wanted to emphasise that using metadata during the project to help direct the project is a real benefit. Typically, the common view is that metadata is collected for follow on projects or other users of the project. The metadata is then like a tombstone: here lies.... RIP

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True.. But would we need both during and within then?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I missed the last bit, edify the project. I don't like this phrase, it has religious connotations to me. I prefer the original inform the decision making as that's more neutral.

Co-authored-by: Jeremy Cohen <[email protected]>
Co-authored-by: Magnus Hagdorn <[email protected]>
@CaptainSifff CaptainSifff merged commit dd4a03b into main Aug 11, 2024
3 checks passed
@CaptainSifff CaptainSifff deleted the yvgrossmann-feedback branch August 12, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

work in feedback from Yves Großmann
7 participants