Suggested edits and minor updates from full review of the paper. #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaptainSifff
requested changes
Aug 8, 2024
jpthiele
reviewed
Aug 9, 2024
jpthiele
reviewed
Aug 9, 2024
jpthiele
reviewed
Aug 9, 2024
jpthiele
reviewed
Aug 9, 2024
jpthiele
added
the
paper_meeting
mhagdorn
approved these changes
Aug 9, 2024
MakisH
reviewed
Aug 9, 2024
knarrff
reviewed
Aug 9, 2024
knarrff
reviewed
Aug 9, 2024
knarrff
reviewed
Aug 9, 2024
Co-authored-by: Gerasimos Chourdakis <[email protected]>
knarrff
reviewed
Aug 9, 2024
Co-authored-by: Gerasimos Chourdakis <[email protected]>
Co-authored-by: Gerasimos Chourdakis <[email protected]>
jcohen02
commented
Aug 9, 2024
knarrff
reviewed
Aug 9, 2024
jcohen02
commented
Aug 9, 2024
jcohen02
commented
Aug 9, 2024
jcohen02
commented
Aug 9, 2024
Co-authored-by: Frank Löffler <[email protected]> Co-authored-by: Jan Philipp Thiele <[email protected]>
jcohen02
commented
Aug 9, 2024
jcohen02
commented
Aug 9, 2024
|
@CaptainSifff, I've made the edits discussed in today's meeting - I think this should now be ready to merge. Feel free to go ahead if you want to merge, otherwise I can do it tomorrow. |
CaptainSifff
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly addresses issue #341.