Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bibliography submodule #282

Merged
merged 8 commits into from
Jun 24, 2024
Merged

Add bibliography submodule #282

merged 8 commits into from
Jun 24, 2024

Conversation

MakisH
Copy link
Collaborator

@MakisH MakisH commented May 27, 2024

Description of changes:

@jngrad
Copy link
Collaborator

jngrad commented May 27, 2024

  • Adds a workflow to update the submodules (manually/on a schedule)

I have reservations about automatically updating the submodule revision: any commit in the BibTeX repository would trigger a new commit in N repositories. If the commit contains a syntax error, CI will break in N repositories. At my institute, we introduced CI in the BibTeX repository to mitigate that issue, and required the update to be done manually, so that the individual updating the submodule is also responsible for checking the entire bibliography in the manuscript.

@MakisH
Copy link
Collaborator Author

MakisH commented May 27, 2024

I can make the workflow manual, that's not a problem.
We definitely don't want a cascade of commits and errors.

@MakisH MakisH requested review from jngrad and CaptainSifff May 27, 2024 16:16
@MakisH MakisH marked this pull request as ready for review May 27, 2024 16:16
Copy link
Collaborator

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jngrad
Copy link
Collaborator

jngrad commented May 31, 2024

Everything works as expected: the-teachingRSE-project/institutionalized_education#4 and compile action 9319020130.

@MakisH
Copy link
Collaborator Author

MakisH commented Jun 1, 2024

From my side, this is ready to merge. I will not join the next two meetings, please go ahead and implement any edits that might pop up.

Copy link
Collaborator

@CaptainSifff CaptainSifff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, technically this looks great!
I now wonder, what the workflow is for MRs like the changes to 266 by @hvwaldow ...

@CaptainSifff CaptainSifff merged commit 0fcafc2 into main Jun 24, 2024
3 checks passed
@jngrad jngrad deleted the add-submodule-bib branch June 24, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants