-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bibliography submodule #282
Conversation
I have reservations about automatically updating the submodule revision: any commit in the BibTeX repository would trigger a new commit in N repositories. If the commit contains a syntax error, CI will break in N repositories. At my institute, we introduced CI in the BibTeX repository to mitigate that issue, and required the update to be done manually, so that the individual updating the submodule is also responsible for checking the entire bibliography in the manuscript. |
I can make the workflow manual, that's not a problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Everything works as expected: the-teachingRSE-project/institutionalized_education#4 and compile action 9319020130. |
From my side, this is ready to merge. I will not join the next two meetings, please go ahead and implement any edits that might pop up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, technically this looks great!
I now wonder, what the workflow is for MRs like the changes to 266 by @hvwaldow ...
Description of changes: