Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServerBanSynchronisationProtection can sometimes desync #507

Closed
Gnuxie opened this issue Aug 13, 2024 · 3 comments
Closed

ServerBanSynchronisationProtection can sometimes desync #507

Gnuxie opened this issue Aug 13, 2024 · 3 comments
Labels
bug Something isn't working L3 Some Users Likelihood MPS Follow Up P2 Aggravating Priority level T5 Major usability Impairs usability in key scenarios.

Comments

@Gnuxie
Copy link
Member

Gnuxie commented Aug 13, 2024

Reported by @TheArcaneBrony.

guessing reproduction steps (no local backing store):
have draupnir moderate 70+ large rooms
manually redact 10 server policies using eg. nheko
wait 10 seconds
restart draupnir
observe draupnir not applying the updated ACLs until causing another ACL update
@Gnuxie Gnuxie added bug Something isn't working L3 Some Users Likelihood P2 Aggravating Priority level T5 Major usability Impairs usability in key scenarios. MPS Follow Up labels Aug 13, 2024
@Gnuxie
Copy link
Member Author

Gnuxie commented Jan 8, 2025

It is possible that the issue was fixed in #650 (problem was that policy revisions were not updating when lists were added / removed) but further investigation is needed.

@Gnuxie
Copy link
Member Author

Gnuxie commented Jan 8, 2025

#499 looks like the same issue

@Gnuxie
Copy link
Member Author

Gnuxie commented Feb 3, 2025

This was caused by multiple problems. Firstly, we never disposed of the protected rooms set properly when coming in and out of safe mode #709. And secondly we never refreshed the room state backing store on restart, we now do Gnuxie/matrix-protection-suite#82.

@Gnuxie Gnuxie closed this as completed Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working L3 Some Users Likelihood MPS Follow Up P2 Aggravating Priority level T5 Major usability Impairs usability in key scenarios.
Projects
Draupnir planning
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Gnuxie