Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR #754 Overwrites Issuer-Requested Labels and Fails Unit Tests #889

Closed
BenjaminatEpic opened this issue Nov 3, 2022 · 1 comment
Closed

PR #754 Overwrites Issuer-Requested Labels and Fails Unit Tests #889

BenjaminatEpic opened this issue Nov 3, 2022 · 1 comment

Comments

@BenjaminatEpic
Copy link
Contributor

BenjaminatEpic commented Nov 3, 2022 •
edited
Loading

@jdkizer9 @edwardjcruz Can you help me determine how we can quickly back out any changes from this PR to Epic organizations? This incorrectly overwrites the websites and naming conventions requested by Epic organizations. At a glance it looks like there is downstream system responsible for copying these changes to the metadata file we would need to consider - is that accurate?

Originally posted by @BenjaminatEpic in #754 (comment)
@BenjaminatEpic
Copy link
Contributor Author

BenjaminatEpic commented Nov 4, 2022 •
edited
Loading

Revert proposed in PR #890

We can look at re-adding some of the data in PR #754, but any additions or changes to Epic organizations should have had their approval first and ideally be in separate PRs.

For context, several of the affected organizations initially actively declined to list websites. PR #754 also effectively undid PR #699.

@BenjaminatEpic BenjaminatEpic mentioned this issue Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edwardjcruz @BenjaminatEpic