Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshing Detail view deselects selection from Master list on iPad #876

Open
ZachOrr opened this issue May 22, 2020 · 1 comment
Open
Labels
bug Issues relating to features that don't work as expected

Comments

@ZachOrr
Copy link
Member

ZachOrr commented May 22, 2020

Describe the bug
On iPad, after selecting an event/team/etc. from the master list on the left-hand side, when the detail view on the right-hand side refreshes, the selection from the master list is deselected.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Events tab (or Events list)
  2. Click on an Event
  3. Pull to refresh on the Event
  4. Notice the selection in the list is now deselected

Expected behavior
The selection in the Master list should stay highlighted, regardless of the Detail refreshing.

Screenshots
ipad-deselect 2020-05-22 16_41_20

Your Environment (please complete the following information):

  • Device: iPad Pro (12.9-inch) (4th generation) (Simulator)
  • OS: iOS 13.5
  • TBA for iOS Version: Dev (2.0.7)
@ZachOrr ZachOrr added the bug Issues relating to features that don't work as expected label May 22, 2020
@ZachOrr
Copy link
Member Author

ZachOrr commented May 23, 2020

Interestingly, this happens in the Events/Teams list but not in the myTBA tab. My guess is that the refresh is updating our backing model and our fetched results controller for the master list is reloading, which means the underlying data is invalidated and our selection gets deselected. The myTBA list works slightly differently where that refresh doesn't reload the underlying data, since it's backed by myTBA models and not Event/Team models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues relating to features that don't work as expected
Projects
None yet
Development

No branches or pull requests

1 participant