New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover with click trigger type stay open #333

Closed

geovie opened this issue Dec 4, 2024 · 1 comment · Fixed by #334

Labels

bug

Contributor

geovie commented Dec 4, 2024

Hi, first thanks for this crate it's really nice to use.

One thing I noticed is that using the click trigger type on popups will keep them open when another popup trigger is clicked.

I guess the issue comes from:
https://github.com/thaw-ui/thaw/blob/main/thaw/src/popover/mod.rs#L135
where the event propagation is stopped on click which prevents the other popups from closing themselves
https://github.com/thaw-ui/thaw/blob/main/thaw/src/popover/mod.rs#L122

To reproduce simply add mulitple popups with trigger type click on the same page and click on the triggers

luoxiaozero added the bug label

luoxiaozero linked a pull request

that will close this issue

Fix/component click outside #334

Merged

luoxiaozero closed this as completed in #334

Collaborator

luoxiaozero commented Dec 5, 2024

Thank you for reporting this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment