Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icon prop in Button does not accept a signal #130

Closed
tqwewe opened this issue Mar 5, 2024 · 2 comments · Fixed by #132
Closed

icon prop in Button does not accept a signal #130

tqwewe opened this issue Mar 5, 2024 · 2 comments · Fixed by #132
Labels
enhancement New feature or request

Comments

@tqwewe
Copy link
Contributor

tqwewe commented Mar 5, 2024

The icon prop in the Button component is of type Option<icondata_core::Icon>, which means it's not possible to change the icon based on a signal.

Is it possible for the icon prop use a signal instead?
@luoxiaozero
Copy link
Collaborator

Yes, I can change it to Option<MaybeSignal<icondata_core::Icon>>.

@luoxiaozero luoxiaozero added the enhancement New feature or request label Mar 5, 2024
@tqwewe
Copy link
Contributor Author

tqwewe commented Mar 6, 2024

@luoxiaozero though if its Option<MaybeSignal<icondata_core::Icon>>, that means you cannot disable the button via a signal right?

Maybe MaybeSignal<Option<icondata_core::Icon>> would be better?

@luoxiaozero luoxiaozero linked a pull request Mar 7, 2024 that will close this issue
feat: Button icon property supports the signal #132
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Button icon property supports the signal thaw-ui/thaw
2 participants
@tqwewe @luoxiaozero