Skip to content

Commit efd8302

Browse files
committed
feat: Binder lazy mount
1 parent bc60868 commit efd8302

File tree

8 files changed

+11
-6
lines changed

8 files changed

+11
-6
lines changed

thaw/src/auto_complete/mod.rs

+1
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ pub fn AutoComplete(
204204
<CSSTransition
205205
node_ref=menu_ref
206206
name="fade-in-scale-up-transition"
207+
appear=is_show_menu.get_untracked()
207208
show=is_show_menu
208209
let:display
209210
>

thaw/src/color_picker/mod.rs

+1
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,7 @@ pub fn ColorPicker(
152152
<CSSTransition
153153
node_ref=popover_ref
154154
name="fade-in-scale-up-transition"
155+
appear=is_show_popover.get_untracked()
155156
show=is_show_popover
156157
let:display
157158
>

thaw/src/date_picker/panel/mod.rs

+1
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ pub fn Panel(
9393
<CSSTransition
9494
node_ref=panel_ref
9595
name="fade-in-scale-up-transition"
96+
appear=is_show_panel.get_untracked()
9697
show=is_show_panel
9798
let:display
9899
>

thaw/src/modal/mod.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ pub fn Modal(
6464
});
6565

6666
view! {
67-
<Teleport>
67+
<Teleport immediate=show.signal()>
6868
<FocusTrap disabled=!close_on_esc active=show.signal() on_esc>
6969
<div
7070
class="thaw-modal-container"
@@ -78,6 +78,7 @@ pub fn Modal(
7878
>
7979
<CSSTransition
8080
node_ref=mask_ref
81+
appear=show.get_untracked()
8182
show=show.signal()
8283
name="fade-in-transition"
8384
let:display
@@ -91,6 +92,7 @@ pub fn Modal(
9192
</CSSTransition>
9293
<CSSTransition
9394
node_ref=modal_ref
95+
appear=show.get_untracked()
9496
show=show.signal()
9597
name="fade-in-scale-up-transition"
9698
on_enter

thaw/src/popover/mod.rs

+2-4
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ pub fn Popover(
110110
children: trigger_children,
111111
} = popover_trigger;
112112

113-
let follower_enabled = RwSignal::new(false);
114113
view! {
115114
<Binder target_ref>
116115
<div
@@ -121,13 +120,12 @@ pub fn Popover(
121120
>
122121
{trigger_children()}
123122
</div>
124-
<Follower slot show=follower_enabled placement>
123+
<Follower slot show=is_show_popover placement>
125124
<CSSTransition
126125
node_ref=popover_ref
127126
name="popover-transition"
127+
appear=is_show_popover.get_untracked()
128128
show=is_show_popover
129-
on_enter=move |_| follower_enabled.set(true)
130-
on_after_leave=move |_| follower_enabled.set(false)
131129
let:display
132130
>
133131
<div

thaw/src/select/mod.rs

+1
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ where
127127
<CSSTransition
128128
node_ref=menu_ref
129129
name="fade-in-scale-up-transition"
130+
appear=is_show_menu.get_untracked()
130131
show=is_show_menu
131132
let:display
132133
>

thaw/src/time_picker/mod.rs

+1
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,7 @@ fn Panel(
178178
<CSSTransition
179179
node_ref=panel_ref
180180
name="fade-in-scale-up-transition"
181+
appear=is_show_panel.get_untracked()
181182
show=is_show_panel
182183
let:display
183184
>

thaw_components/src/binder/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ fn FollowerContainer<El: ElementDescriptor + Clone + 'static>(
239239
)
240240
});
241241

242-
view! { <Teleport element=children/> }
242+
view! { <Teleport element=children immediate=show/> }
243243
}
244244

245245
fn get_scroll_parent(element: Option<HtmlElement<AnyElement>>) -> Option<HtmlElement<AnyElement>> {

0 commit comments

Comments
 (0)