Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update takes 11 minutes #3

Open
Maathias opened this issue May 23, 2023 · 4 comments
Open

Update takes 11 minutes #3

Maathias opened this issue May 23, 2023 · 4 comments
Assignees

Comments

@Maathias
Copy link

Running oui update, populating database is very slow. Seeing as in README example update takes 14 seconds, I assume this is a bug.
Installed from AUR using yay. My system:
OS: Manjaro Linux x86_64
Kernel: 6.3.3-1-MANJARO
CPU: AMD Ryzen 5 3400G (8)

:~ % oui update           

Updating MAC Address Database
██████████████████████████████████████████████████ 100.0% Completed
Updated MAC Address database (v0) with 48,822 records in 11 minutes
@thatmattlove
Copy link
Owner

Hi @Maathias, can you try this again on the latest version? v2.0.4 should be available via package managers in the next hour or so.

The speed of the update process is completely dependent upon the speed of the machine (both CPU and disk), but I did try to optimize this as much as possible in v2. I updated it on my machine (M2 Max MacBook Pro) a few minutes ago and it took 9 seconds.

To be fair, I haven't done much testing on slower machines. Though, the CI actions seem to finish in <2 minutes, and I'd imagine those VMs/containers are very limited at the free tier.

Let me know if this is still an issue for you and I'll see what I can do.

@thatmattlove thatmattlove self-assigned this Oct 23, 2023
@Maathias
Copy link
Author

Hi, v2.0.4 works fine now, 14 seconds.
I checked the AUR version, and it's at v0.1.8, that might be the problem
https://aur.archlinux.org/packages/oui

@thatmattlove
Copy link
Owner

It looks like somebody named "patrickh" submitted it to AUR. I don't have an AUR account or any knowledge about Arch or the packaging system. Is this something you could easily update? I do see an option to "flag package as out-of-date", not sure if that does anything automagically.

@Maathias
Copy link
Author

When logged in you can flag packages. I flagged it out-of-date, maybe the maintainer will do something about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants