Fix: load background video #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why: dependencies incompatible,[email protected] - expected version: ~15.4.5 how: with npx expo install --fix
How: add image poster while the video loading as a child in Video component Why: make the transition more smoother What: fix: taking time to load background image/video
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
It's great having you contribute to this project
🌟 Welcome to the community 🌟
- If you would like to continue contributing to open source and would like to do it with an awesome inclusive community.
- You should join our Discord chat and our GitHub Organisation.
- We help and encourage each other to contribute to open source little and often 😄.
- Any questions let us know.
|
@kabir0x23 what do you think about this implementation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #16
Changes proposed
There are two solutions that we can apply (if you think about a better solution, pls, share with me :))
Screenshots
Recording.2023-11-24.003633.mp4
Note to reviewers
I chose the imageStyle opacity to be 0.9 , in my opinion, it looks better.
@kabir0x23
Code of Conduct
Check List (Check all the applicable boxes)
You can also join our Discord community.
Feel free to check out other cool repositories of the Thecyberworld.
Join the Thecyberworld GitHub Organisation by raising an issue (you will be sent an invitation).