-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE for Developers] Add And Configure ESlint and Prettier #81
[FEATURE for Developers] Add And Configure ESlint and Prettier #81
Conversation
Why: it is very important to have Eslint for errors and Prettier for code format How: Add Eslint and Prettier configure and solve bugs that it alerted about What: Add And Configure ESlint and Prettier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great having you contribute to this project
🌟 Welcome to the community 🌟
- If you would like to continue contributing to open source and would like to do it with an awesome inclusive community.
- You should join our Discord chat and our GitHub Organisation.
- We help and encourage each other to contribute to open source little and often 😄.
- Any questions let us know.
I am a little bit confused, you have some files that use typescript so I added to eslint the right configurations. However, you also have files that don't use typescript. Do you want to use typescript in the project or not? Do you want me to open an issue about this topic? @kabir0x23 |
I think ts is only being used in 1 or 2 components if we convert the project into the type it will take time... will think, and u can create issues according to what u think will be better for project thank you, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contributions @ArkadiK94
Will review and merge it by today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contrbutions,
and apllogise for delay.
It is ok. I opened a new issue about typescript #84 , however, in this pr, I changed some files to tsx and I am not sure if I should leave it or change to jsx. Do you want to merge this pr and think about it in the relevant issue? |
@kabir0x23 Could you merge this pr and we will talk about ts in the relevant pr? |
yes sure Thanks for your contrbutions, and apllogise for delay again. |
Why: it is very important to have Eslint for errors and Prettier for code format
How: Add Eslint and Prettier configure and solve bugs that it alerted about
What: Add And Configure ESlint and Prettier
Fixes Issue
Closes #77
Changes proposed
configure ESlint and Prettier similar as in the "TheCyberHUB" project , for better development experience
I used a package eslint-config-universe because it is the recommended one from the expo docs
https://docs.expo.dev/guides/using-eslint/
Screenshots
There has not been made a visual change
Note to reviewers
The changes in files and some files extension was needed for the ESlint to pass.
Code of Conduct
Check List (Check all the applicable boxes)
You can also join our Discord community.
Feel free to check out other cool repositories of the Thecyberworld.
Join the Thecyberworld GitHub Organisation by raising an issue (you will be sent an invitation).