Fix/old-bugs #76
Merged
Fix/old-bugs #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What: Update the packages for the app to work Why: It effects the usability of the app How: npx expo install --fix
What: Fix tabBarOptions deprecated error Why: In new version of react-navigation they removed the tabBarOptions How: Move the tabBarOptions to screenOptions
What: Fix this bug: "LOG errrrrr: [Error: Call to function 'ExponentFileSystem.downloadResumableStartAsync' has been rejected. → Caused by: java.lang.IllegalArgumentException: Expected URL scheme 'http' or 'https' but no colon was found]" Why: It happens from the expo-fast-image package , I didn't find this package in expo site How: I changed it to 'Image' instead 'ExpoFastImage'
What: Fix bugs in jobs screen : 1. no valid icon , 2. keys should be unique How: 1. need to use data.type and not data.labe, 2. add key property when needed Why: Needed to be fixed * Change the react-native-vector-icons to @expo/vector-icons a wrapper for react-native-vector-icons
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
It's great having you contribute to this project
🌟 Welcome to the community 🌟
- If you would like to continue contributing to open source and would like to do it with an awesome inclusive community.
- You should join our Discord chat and our GitHub Organisation.
- We help and encourage each other to contribute to open source little and often 😄.
- Any questions let us know.
|
Amazing, yes u can.. |
kabir0x23
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was not an issue for this pr. Do you want me to open one?
Fixes Issue
Changes proposed
Fix Update Packages : npx expo install --fix
Fix tabBarOptions deprecated: Move the tabBarOptions to screenOptions
Fix Courses Screen Bug: I changed it to 'Image' instead 'ExpoFastImage'
Fix Bugs In Jobs Screen: 1. need to use data.type and not data.label, 2. add key property when needed
Screenshots
Note to reviewers
Code of Conduct
Check List (Check all the applicable boxes)
You can also join our Discord community.
Feel free to check out other cool repositories of the Thecyberworld.
Join the Thecyberworld GitHub Organisation by raising an issue (you will be sent an invitation).