Skip to content

Commit c99faa1

Browse files
seebsfhaynes
authored andcommitted
bump timeout on overlapping write requests test
At 50ms, we see sporadic failures in CI. So much for "this should only need a couple milliseconds". Bumped timeout to avoid that. The challenge here is that we have some tests which *want* to hit the timeout to confirm that we aren't allowing things we shouldn't. But we don't want the test to hang forever. But we want to be sure it is actually stuck and not just being slow... (cherry picked from commit f1a68f8)
1 parent 2709973 commit c99faa1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

querycontext/query_context_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ func testOverlappingWriteRequests(t *testing.T, write overlappingWriteReqs) erro
400400
}
401401
t.Fatalf("running reqs: %v", err)
402402
}
403-
case <-time.After(50 * time.Millisecond):
403+
case <-time.After(250 * time.Millisecond):
404404
if !write.shouldError {
405405
// Only log this if we didn't expect an error.
406406
t.Logf("write requests (%d):", len(write.reqs))

0 commit comments

Comments
 (0)