Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figure out how to sanely set ontology local repo at runtime #82

Open
tgbugs opened this issue Jun 17, 2020 · 0 comments
Open

figure out how to sanely set ontology local repo at runtime #82

tgbugs opened this issue Jun 17, 2020 · 0 comments

Comments

@tgbugs
Copy link
Owner

tgbugs commented Jun 17, 2020

Right now there is a missing level of indirection between the olr sourced from the auth config and the repo that is used or can be set at runtime. This mostly affects older code where those things were hardcoded, however it points to what may be a deeper issue with orthauth which is that there is no way to override/inject values at runtime. This is not a bug in orthauth, orthauth has support for setting configurations at runtime that was originally developed to make testing simpler (which is the same underlying use case that motivates the immediate issue here as well). Rather, the issue is that values are sourced from the auth config at import time which means that they are effectively static global variables, this is the missing level of indirection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant