Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch reassignment of sample sets should be based on names, not ids #22

Open
percyfal opened this issue Nov 7, 2024 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@percyfal
Copy link
Collaborator

percyfal commented Nov 7, 2024

Currently batch reassignment of sample sets is based on ids, but for clarity should be based on names. I had a go at this but with the current implementation it is trickier than anticipated. Basically, the individuals_table needs a new column with the current sample set name which is defined in the sample_sets_table. However, the latter is editable and is updated from time to time with new sample sets, which would need propagation to the individuals_table. Currently, the tables are sort of oblivious to each other's existence.

@percyfal percyfal added the enhancement New feature or request label Nov 7, 2024
@percyfal
Copy link
Collaborator Author

Draft code (not working correctly though) is available at https://github.com/percyfal/tseda/tree/ssnames

@hannamlmv
Copy link
Collaborator

hannamlmv commented Dec 11, 2024

Similar to: hannamlmv#97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants