-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend support to tensors #12
Comments
Using The main reason its a big change is that you can't dynamically specify the rank of a tensor whereas you can dynamically specify the rows/cols of a matrix. For matrices you can do:
With tensors the rank cannot be set to dynamic:
4 is the rank and then the dimensions are set to 4, 5, 6 and 7. So when storing this Tensor object in a class you would have to have a member for every rank of tensor you want to support. There's a lot to be learned from Tensorflow and how they support tensors. They use Another route I was thinking about was adding a dtype to tensorflow for big tensors. This would be pretty cool but its not clear if this is actually possible and how involved it would be to make work. |
Excellent, thanks for the write-up @justin1121! FWIW I agree that following TF makes a lot of sense.
If this works it would be great! |
Right now we only support matrices; using eg https://eigen.tuxfamily.org/dox-devel/unsupported/eigen_tensors.html we might support more general tensors as well
The text was updated successfully, but these errors were encountered: