Skip to content
This repository has been archived by the owner on Apr 13, 2021. It is now read-only.

Fix issues with restarting db from threadid vs cold start vs fromInfo #396

Closed
andrewxhill opened this issue Jul 14, 2020 · 1 comment
Closed
Assignees
Labels
invalid This doesn't seem right wontfix This will not be worked on

Comments

@andrewxhill
Copy link
Member

each of these cases is slightly different, restart from known threadid, start from randomid, and start from addr before you know the id. the current name mapping kinda breaks this if you try to juggle more than one, since you have to deterministically set the db name on start. or you hit mismatch issues. we fixed one of these last week while sorta creating another. new proposal,

  1. scrap db names and just use string of threadid (sure, override if 🤠 )
  2. that works for all but fromInfo, so we need to add a method internally that will figure out the addr before finalizing the start.
  3. we could likely move start, startfrominfo to be static methods to just make this really clear and not bother with setting up any db before you are ready to commit to a threadid. or start a new one if you need to change
@carsonfarmer carsonfarmer added wontfix This will not be worked on invalid This doesn't seem right labels Sep 25, 2020
@carsonfarmer carsonfarmer self-assigned this Sep 25, 2020
@carsonfarmer
Copy link
Member

This was an issue with the previous threads-database implementation. Closing this as "no longer relevant" in favor of work in the ongoing Great Refactor (#414).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants