Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PHP 5 support #200

Open
7 tasks
gocom opened this issue Dec 15, 2019 · 0 comments
Open
7 tasks

Drop PHP 5 support #200

gocom opened this issue Dec 15, 2019 · 0 comments

Comments

@gocom
Copy link
Member

gocom commented Dec 15, 2019

We should increase required PHP version to 7.2, dropping unsupported PHP versions in PHP-Textile 4.0.0.

This should be done with minimal code changes to make transition smoother, but we should add strict type hints, return types and interfaces for both the parser and its configuration getters/setters.

This would make the library much more useable in modern context, prepare it for future improvements and being able to use newer PHP features, and resolve issues with dev/test dependency blockers. Itself the usage of the library and API would stay the same.

Process:

  • Change the current (private, but) protected properties and methods to private.
  • Add strict-type checks, and argument and return types.
  • ParserInterface and ConfigInterface, both implemented by the current parser.
  • Update development dependencies.
  • Remove getVersion() and version number from Parser to simplify release process.

Further:

  • After getVersion is gone, automate release process with GitHub actions.
  • After automation and version bumps are unnecessary, change branching model to PR only. Disallow direct pushes to master; feature branches only. Tests must pass before branch can be merged. Non-maintainer PRs require approvals.
@gocom gocom added this to the 4.0.0 milestone Dec 15, 2019
@gocom gocom self-assigned this Dec 15, 2019
gocom added a commit that referenced this issue Dec 15, 2019
Implements interfaces and adds type coverage to public API.

See #200
@gocom gocom modified the milestones: 4.0.0, 5.0.0 Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant