From b880be9889867ec301df768b89f31009dc0db428 Mon Sep 17 00:00:00 2001 From: Christian Siebmanns Date: Mon, 11 Sep 2023 20:46:24 +0200 Subject: [PATCH 1/2] Add stronger types --- projects/testing-library/src/lib/models.ts | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/projects/testing-library/src/lib/models.ts b/projects/testing-library/src/lib/models.ts index 2e198a6..9d771be 100644 --- a/projects/testing-library/src/lib/models.ts +++ b/projects/testing-library/src/lib/models.ts @@ -1,4 +1,4 @@ -import { Type, DebugElement } from '@angular/core'; +import { Type, DebugElement, ModuleWithProviders, EnvironmentProviders, TypeProvider } from '@angular/core'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { Routes } from '@angular/router'; import { BoundFunction, Queries, queries, Config as dtlConfig, PrettyDOMOptions } from '@testing-library/dom'; @@ -65,6 +65,12 @@ export interface RenderResult extend ) => Promise; } +export interface ProviderInterface { + provide: any; + useValue: any; + multi?: boolean; +} + export interface RenderComponentOptions { /** * @description @@ -128,7 +134,7 @@ export interface RenderComponentOptions; /** * @description * A collection of imports needed to render the component, for example, shared modules. @@ -147,7 +153,7 @@ export interface RenderComponentOptions | ModuleWithProviders | any[]>; /** * @description * A collection of schemas needed to render the component. @@ -231,7 +237,7 @@ export interface RenderComponentOptions; /** * @description * Collection of child component specified providers to override with From 04c97117896309cd91e0afd0b58ab7bfeed71ae8 Mon Sep 17 00:00:00 2001 From: Christian Siebmanns Date: Mon, 25 Sep 2023 21:46:38 +0200 Subject: [PATCH 2/2] Fix review feedback --- projects/testing-library/src/lib/models.ts | 26 +++++++++++++--------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/projects/testing-library/src/lib/models.ts b/projects/testing-library/src/lib/models.ts index 9d771be..a2af859 100644 --- a/projects/testing-library/src/lib/models.ts +++ b/projects/testing-library/src/lib/models.ts @@ -1,4 +1,14 @@ -import { Type, DebugElement, ModuleWithProviders, EnvironmentProviders, TypeProvider } from '@angular/core'; +import { + Type, + DebugElement, + ModuleWithProviders, + EnvironmentProviders, + Provider, + ValueProvider, + ClassProvider, + ExistingProvider, + FactoryProvider, +} from '@angular/core'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { Routes } from '@angular/router'; import { BoundFunction, Queries, queries, Config as dtlConfig, PrettyDOMOptions } from '@testing-library/dom'; @@ -65,12 +75,6 @@ export interface RenderResult extend ) => Promise; } -export interface ProviderInterface { - provide: any; - useValue: any; - multi?: boolean; -} - export interface RenderComponentOptions { /** * @description @@ -113,7 +117,7 @@ export interface RenderComponentOptions | any[]>; /** * @description * A collection of providers needed to render the component via Dependency Injection, for example, injectable services or tokens. @@ -134,7 +138,7 @@ export interface RenderComponentOptions; + providers?: Array; /** * @description * A collection of imports needed to render the component, for example, shared modules. @@ -153,7 +157,7 @@ export interface RenderComponentOptions | ModuleWithProviders | any[]>; + imports?: Array | ModuleWithProviders>; /** * @description * A collection of schemas needed to render the component. @@ -237,7 +241,7 @@ export interface RenderComponentOptions; + componentProviders?: Array; /** * @description * Collection of child component specified providers to override with