feat(servicebus): Add support to use a custom MsSqlContainer instance with Service Bus emulator #1335
+99
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ServiceBusContainer
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lgcmotta
commented
Jan 12, 2025
Comment on lines
+45
to
+51
| var typeAssemblyName = containerType.Assembly.GetName().Name; | ||
|
|
||
| if (!string.IsNullOrWhiteSpace(testAssemblyName) && !string.IsNullOrWhiteSpace(typeAssemblyName) && !testAssemblyName.Contains(typeAssemblyName)) | ||
| { | ||
| continue; | ||
| } | ||
|
|
There was a problem hiding this comment.
When adding a new test that creates an MS SQL instance, the MsSqlContainer type was exported under Testcontainers.ServiceBus.Tests.dll. This caused the test to detect IContainer implementations that aren’t part of the Service Bus assembly. Ideally, verifying that MsSqlContainer implements IDatabaseContainer should happen in its theory case (Testcontainers.MsSql.Tests), rather than in the Testcontainers.ServiceBus.Tests.dll theory case.
I’d appreciate any suggestions on how to handle these cross-assembly references without causing false positives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR exposes an overload of
WithMsSqlContainer, enabling users to attach an existingMsSqlContainerinstance to the Azure Service Bus emulator. Previously, ServiceBusContainer automatically spun up its own SQL Server container, leading to unnecessary duplication when users were already testing with Azure Service Bus and SQL Server (see #1323).Why is it important?
This enhancement addresses the resource usage issues described in #1323. By allowing a single
MsSqlContainerto be shared, the overhead of launching a separate SQL Server container to use the Azure Service Bus emulator is eliminated. This can be especially beneficial in CI/CD scenarios or other environments where minimizing resource consumption and reducing test execution time is a priority.Related issues
How to test this PR
MsSqlContainertoServiceBusContainer.ServiceBusContainerandMsSqlContainer) are on the same network.mcr.microsoft.com/azure-sql-edge:latest.mcr.microsoft.com/mssql/server:2022-CU14-ubuntu-22.04(the default inMsSqlBuilder) is not spun up.Follow-ups
None at this time. Inline summary documentation is included in the new overload.