Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add Support for Emulator for Azure App Configuration #1198

Open
tnc1997 opened this issue Jun 13, 2024 · 2 comments · May be fixed by #1200
Open

[Enhancement]: Add Support for Emulator for Azure App Configuration #1198

tnc1997 opened this issue Jun 13, 2024 · 2 comments · May be fixed by #1200
Labels
enhancement New feature or request module An official Testcontainers module

Comments

@tnc1997
Copy link

tnc1997 commented Jun 13, 2024

Problem

I am the maintainer of an emulator for Azure App Configuration and I have received feedback from users that they would value a Testcontainer module to allow them to more easily test their applications.

Solution

I would like to contribute a module for the emulator and was wondering if this should be done in this repository and published as Testcontainers.AzureAppConfiguration or similar or hosted in the emulator's repository.

Benefit

The benefits of having a module for the emulator include being able to more quickly and easily enable integration tests of applications that are dependent on Azure App Configuration.

Alternatives

I would be more than happy to alternatively maintain the aforementioned module in the emulator's repository and publish it as AzureAppConfigurationEmulator.Testcontainers or similar.

Would you like to help contributing this enhancement?

Yes

@HofmeisterAn
Copy link
Collaborator

Hi 👋 interesting project. Emulators for cloud services complement each other well with Testcontainers.

was wondering if this should be done in this repository and published as Testcontainers.AzureAppConfiguration or similar or hosted in the emulator's repository.

This is up to you. Modules do not need to be maintained in this repository. The advantage right now is that we will publish a new module version together with a new Testcontainers release.

Is there already a public Docker image available? If you follow our best practices and align with all the other existing modules, I am happy to review your PR and appreciate the contribution. However, please be aware that I am quite busy these days and have some other reviews to take care of first. It might take some time.

Regardless of your decision, feel free to submit a PR to add your module to the module catalog. Also, do not hesitate to ask questions or ask for guidance, either here or in Slack.

@tnc1997
Copy link
Author

tnc1997 commented Jun 13, 2024

Hi @HofmeisterAn, thank you very much for getting back to me so promptly!

Is there already a public Docker image available?

Yes, there is a public image available on Docker Hub.

However, please be aware that I am quite busy these days and have some other reviews to take care of first.

That is entirely understandable and no problem at all, I will look to put something together and submit a PR 😄

@HofmeisterAn HofmeisterAn added the module An official Testcontainers module label Jun 13, 2024
@tnc1997 tnc1997 linked a pull request Jun 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module An official Testcontainers module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants