Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with minimum_delta for Location #332

Open
EmilOlovsson opened this issue Jan 28, 2025 · 5 comments
Open

Issue with minimum_delta for Location #332

EmilOlovsson opened this issue Jan 28, 2025 · 5 comments
Labels
enhancement New feature or request

Comments

@EmilOlovsson
Copy link

How do I implement minimum_delta correctly for "Location"?

The vehicle is a Model 3 running software V12 (2024.45.32.2)

I've set minimum_delta set to 0.0001 for Location but still receive data that has very small changes:

{"data":[{"key":"Location","value":{"locationValue":{"latitude":YY.609382,"longitude":XX.099705}}}],"createdAt":"2025-01-28T17:04:28.921265359Z","vin":"XXX"}

{"data":[{"key":"Location","value":{"locationValue":{"latitude":YY.609382,"longitude":XX.099704}}}],"createdAt":"2025-01-28T17:06:29.234057117Z","vin":"XXX"}

@patrickdemers6
Copy link
Collaborator

Location doesn't support minimum_delta yet, we will be shipping that in a new release soon.

@patrickdemers6
Copy link
Collaborator

It will be in meters, so if you pass min delta of 10, it will send when location changes by 10+ meters.

@rawmean
Copy link

rawmean commented Jan 29, 2025

can you please consider stop charging for API before a new firmware that supports minimum_delta is pushed to majority of cars? Otherwise, we are charged for data that we have not requested?

@marklindsey
Copy link

Very happy to hear this @patrickdemers6! Will this require a telemetry server code change also or simply a vehicle telemetry config change?

@fredli74
Copy link

fredli74 commented Feb 1, 2025

It will be in meters, so if you pass min delta of 10, it will send when location changes by 10+ meters.

Odd, I expected it to be in decimal degrees (that's how I implemented it). I get it, "location" is a compound of latitude and longitude. At least I'm happy you went with meters as opposed to the "odometer" values. 😉

@thefireblade thefireblade added the enhancement New feature or request label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants