"null" car_id for multiple graphs

[arcastro]

Hello,

Many of my graphs on grafana show a "null" car_id.

Is this expected?

For example, here is my "mileage" graph

What is the car_id expected to be? VIN? custom name?

I appreciate the help

[cwanja]

car_id should be a unique value assigned to a car record in the database. It's odd you have no ID.

From the Explore part of Grafana, can you run a select * from cars; and share? Mask any data you'd like.

[arcastro]

I do see one row returned

Does this mean the $car_id should be simply 1?

[brianmay]

I have seen this happen when I don't have a name set for the car.

[cwanja]

It is not really an "issue", everything is working as intended. This would be an enhancement which would have to be picked up by anyone who could develop the capability. I have gone ahead and changed it to an Idea.

[arcastro]

It is not really an "issue", everything is working as intended.

I think displaying null for unnamed vehicles would be viewed as a bug by most people 😉, although I agree it's low-priority since it's only cosmetic and there is an easy mitigation (naming your vehicle).

I'd be happy to submit a pull request updating the locations here. I still think this is a presentation issue that should be handled at the presentation layer, rather than an issue with the data in the database (since the data in the database is actually correct).

Otherwise, I'm okay to let this sit for now. Ty for updating the discussion category :)

[cwanja]

I think displaying null for unnamed vehicles would be viewed as a bug by most people 😉

But an unnamed vehicle is null right? At this point, we would be arguing over semantics 😁

I'd be happy to submit a pull request updating the locations here.

By all means, go for it! We love contributors. The lovely team here will review and give feedback and the discussion can move from here to that PR. And if the time comes where a revision makes its way into the code that writes to the database, your changes could be undone.

[arcastro]

But an unnamed vehicle is null right?

😄 you got me there!
And ty again I'll follow up soon

[arcastro]

opened here: #4198

[arcastro]

Resolved in #4198
And released in https://github.com/teslamate-org/teslamate/releases/tag/v1.31.0