[Bug]: ClaimHandler.read can cause a watchdog timeout

[Jamalam360]

Bug Description

The methods earth.terrarium.cadmus.common.claims.ClaimHandler.read and com.teamresourceful.resourcefullib.common.utils.SaveHandler.read can timeout the server and cause it to be killed by the watchdog.

I have specifically ran into this twice through the earth.terrarium.cadmus.common.claims.ClaimApiImpl.canDamageEntity method.

How to Reproduce?

This is how we've caused it, twice:

1. Go into player 1's claim
2. Get Player 2 to shoot arrows at blocks or at player 1
3. (optional? may not be needed) get player 2 to pick up the arrows from the blocks

Expected Behavior

The method should not trigger the watchdog 😆

Version

1.0.0

Mod Loader Version

1.20.1 0.19.2

Mod Loader

Quilt

Logs or additional context

https://mclo.gs/luPwtPQ

Code of Conduct

• I have searched the issue tracker and confirmed that the issue has not been reported
• I have checked the FAQ (if one is present) and my issue is not listed
• I have verified that I am using the latest version of the mod
• I have verified that I have installed all the required dependencies for the mod
• I have verified that I do not have Optifine installed. We will close issues if we detect Optifine is in your pack. We cannot fix Optifine issues. Please do not report issues with Optifine present.

[ThatGravyBoat]

The method that its timing out on is literally a vanilla call

[Jamalam360]

OK, well that doesn't rule out Cadmus from being at fault in particular. Is there a chance that the NBT it's trying to save is huge/wrong in some other way?

[ThatGravyBoat]

the nbt for cadmus is very small like extremely small, its 8 bytes per chunk and then 38 bytes for the key so if you had 100k chunks thats less than an mb

[Jamalam360]

This is odd then. I've done a mixin export and SavedData is clean, nothing suspicious there.

[AlexNijjar]

Have you ran into this any more times since the initial report? I've been unable to reproduce it, and as gravy said, it's watchdoging on a vanilla call. Perhaps one of the other mods you have installed is messing with nbt reading?

[Jamalam360]

It still occurs every time the reproduction step happens, but I haven't updated the pack in a while so it might have been fixed. The mixin export didn't show anything immediately suspicious but I didn't look too deep into it