[Bug] [1.20.1 Forge] [1.20.4 NeoForge]: Connected textures don't support emissive rendering when smooth lighting is on

[roberttkahelin8]

Bug Description

Any block that uses CTMs don't support emissive textures (emissive like the magma block, vanilla methods) when smooth lighting is on. This seems to be the case for Forge and NeoForge (1.20.1 and 1.20.4). Also, emissive rendering that the modloader supplies only works on non-athena block model blocks, so vanilla emissive rendering had to be used. The item model is uneffected by this bug.

The image below shows the broken blocks when smooth lighting is on next to a block and item in the itemframe that use the built-in emissive rendering feature of forge/neoforge (and vanilla emissive rendering is on as well).

It should look like this (image shows smooth lighting off next to the same block and item in the itemframe):

This bug is very annoying because most people play with smooth lighting on, thus making my blocks appear uninteresting unless they turn off smooth lighting. The edges of the CTM models seem to be glowing a tiny bit.

How to Reproduce?

Make any block in a mod and use Athena CTMs (any model loader type) and enable emissive rendering on it (in code).

Turn on smooth lighting in settings.

Look at the blocks.

They won't be emissive until smooth lighting is turned off.

Expected Behavior

Blocks' textures connect and emissive rendering works in smooth lighting as well as no smooth lighting.

Version

3.3.0 (neoforge), 3.1.1 (forge)

Mod Loader Version

1.20.4-20.4.167 (neoforge), 1.20.1-47.2.0 (forge)

Mod Loader

NeoForge, Forge

Logs or additional context

Emissive rendering must be applied in the block constructor for this bug to appear.

No rendering changing mods were installed.

The forge and neoforge version don't matter as much, as this model issue applies to multiple versions of the modloaders (tested in 47.2.6+ on forge, neoforge behavior is the same on multiple versions).

No mods have ever tried doing emissive rendering with athena's CTMs ever, so this is a very specific issue. Though the library should support it as other mods in the past have had CTMs with emissive glowing applied to them.

Code of Conduct

• I have searched the issue tracker and confirmed that the issue has not been reported
• I have checked the FAQ (if one is present) and my issue is not listed
• I have verified that I am using the latest version of the mod
• I have verified that I have installed all the required dependencies for the mod
• I have verified that I do not have Optifine installed. We will close issues if we detect Optifine is in your pack. We cannot fix Optifine issues. Please do not report issues with Optifine present.

[roberttkahelin8]

For additional context here is a code snippet (for forge) of the block constructor that uses emissive rendering: https://pastebin.com/rHLJrdVw