Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use web_url in views/Plugin/Satis/Inventory/view.html.twig to link package? #85

Open
NeoBlack opened this issue Feb 12, 2018 · 2 comments
Labels
Milestone

Comments

@NeoBlack
Copy link
Contributor

The web_url in the database should be used to link dependencies in views/Plugin/Satis/Inventory/view.html.twig instead of linking packages on packagist.org which are not available.

@tyler-sommer
Copy link
Member

Agreed, nice catch. Thanks for the bug report!

@tyler-sommer tyler-sommer added this to the 3.2.1 milestone Feb 13, 2018
@FrankGiesecke
Copy link
Contributor

This would be nice.

But aware, that the web_url doesn't contain the URL of the terramar-labs/packages instance.

Also aware, that there can be a mix of public packages (packagist.org), private packages (packagist.com) and self hosted packages (terramar-labs/packages instance).

As there is no further information in the link provided by the composer repository, it seems difficult to identify the packages.
It might be useful to store the package name in the database, so the property target could be used to identify self hosted packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants