feat: migrate namespace to TIM #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
FYI, repo has to be renamed. PR -> #3 |
ocofaigh
requested changes
Feb 6, 2024
.github/settings.yml
Outdated
|
|
||
| # The description is displayed under the repository name on the | ||
| # organization page and in the 'About' section of the repository. | ||
|
|
||
| # Uncomment this description property | ||
| # and update the description to the current repo description. | ||
| # description: "" | ||
| description: "Creates Kubernetes namespaces with custom metadata." |
There was a problem hiding this comment.
Configures a Kubernetes namespace or Openshift project
README.md
Outdated
| @@ -1,28 +1,31 @@ | |||
| <!-- Update the title --> | |||
| # Terraform Modules Template Project | |||
| # Namespace Modules | |||
README.md
Outdated
| [-red)](https://terraform-ibm-modules.github.io/documentation/#/badge-status) | ||
| [](https://github.com/terraform-ibm-modules/terraform-ibm-module-template/releases/latest) | ||
| [-brightgreen)](https://terraform-ibm-modules.github.io/documentation/#/badge-status) | ||
| [](https://github.com/terraform-ibm-modules/terraform-ibm-namespace-module/releases/latest) |
There was a problem hiding this comment.
repo was renamed, so this needs to be updated
README.md
Outdated
|
|
||
| ## Compliance and security | ||
|
|
||
| NIST controls do not apply to this module. |
There was a problem hiding this comment.
Remove Compliance and security section - We don't add it for TIM repos
README.md
Outdated
| # Namespace Module | ||
| ############################################################################## | ||
|
|
||
| # Replace "main" with a GIT release version to lock into a specific release |
README.md
Outdated
|
|
||
| # Replace "main" with a GIT release version to lock into a specific release | ||
| module "namespace" { | ||
| source = "terraform-ibm-modules/namespace-module/ibm" |
There was a problem hiding this comment.
repo was renamed, so update this
examples/basic/README.md
Outdated
| @@ -1,11 +1,11 @@ | |||
| # Basic example | |||
| # Basic Example | |||
examples/basic/main.tf
Outdated
|
|
||
| module "resource_group" { | ||
| source = "terraform-ibm-modules/resource-group/ibm" | ||
| version = "1.1.4" | ||
| source = "git::https://github.com/terraform-ibm-modules/terraform-ibm-resource-group.git?ref=v1.1.4" |
There was a problem hiding this comment.
please use terraform-ibm-modules/resource-group/ibm
6 tasks
|
/run pipeline |
ocofaigh
requested changes
Feb 8, 2024
.github/settings.yml
Outdated
| @@ -22,7 +22,7 @@ repository: | |||
|
|
|||
| # Uncomment this description property | |||
| # and update the description to the current repo description. | |||
| # description: "" | |||
| description: "Configures a Kubernetes namespace or Openshift project." | |||
|
|
|||
| # Use a comma-separated list of topics to set on the repo (ensure not to use any caps in the topic string). | |||
| topics: terraform, ibm-cloud, terraform-module | |||
There was a problem hiding this comment.
please add these topics too: core-team, supported, graduated, namspace, project, kubernetes, openshift
|
/run pipeline |
ocofaigh
approved these changes
Feb 8, 2024
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migration of namespace module to public
https://github.ibm.com/GoldenEye/issues/issues/6992
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers