Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reexporting crates for which ShaderType are implemented #51

Open
Tomaz-Vieira opened this issue Sep 2, 2023 · 3 comments · May be fixed by #54
Open

Consider reexporting crates for which ShaderType are implemented #51

Tomaz-Vieira opened this issue Sep 2, 2023 · 3 comments · May be fixed by #54
Labels
enhancement New feature or request

Comments

@Tomaz-Vieira
Copy link

Could you reexport crates like nalgebra to make sure consumers of encase are using the exact types for which ShaderType is implemented?

Right now, I think the only way to handle this is to manually check the version of nalgebra being used by encase and add that as a direct dependency of the dependent project.

Also, thank you for the amazing work =)

@teoxoy teoxoy added the enhancement New feature or request label Sep 11, 2023
@teoxoy
Copy link
Owner

teoxoy commented Sep 11, 2023

Thank you! :)

Reexporting the crates sounds reasonable, would you like to open a PR?

@Tomaz-Vieira
Copy link
Author

I think I can give it a shot over the weekend =) I'll have to look around and see what the best practices for this are

Tomaz-Vieira added a commit to Tomaz-Vieira/encase that referenced this issue Oct 8, 2023
@Tomaz-Vieira
Copy link
Author

Hey, sorry it took me this long to get back to this, but here:

Does this look ok to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants