-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ModuleNotFoundError
: 1.4.0 (and below, possibly) missing an explicit future
dependency
#257
Comments
My team's using We worked around by adding The error messages will say |
@rcrowe-google any chance to get a patch release for this 1.4.1? Seeing also some issues here on CI - https://github.com/tensorflow/tfx-addons/runs/5031481438?check_suite_focus=true |
Same here. I'm using |
FYI, |
This issue can probably be closed since #262 is merged. People can probably reopen if they really need for older versions. |
This shouldn't be needed as the dependency on future was removed in 1.5, did you run into an issue with 1.5 or 1.6? See 1.4.1
v.s. 1.5
|
@zoyahav I see, thanks! This can probably be closed then. |
Thanks for verifying! |
As of right now, new installations of
tensorflow-transform==1.4.0
fail to import with aModuleNotFoundError
because thefuture
library is not marked as a dependency in the setup.py.This likely wasn't a problem before because some recursive dependency of tft depended on
future
, masking the issue. Butfuture
is a hard dependency of tft 1.4.0, as it is imported onimport tensorflow_transform
, so it should probably be added as a dep in a1.4.1
release (assuming this team does back-releases of that kind).For people looking for a hotfix in your own project, adding
future
as a dependency of your project should be enough.This isn't a problem in 1.5.0 because the only usage of
future
was removed in this commit.The text was updated successfully, but these errors were encountered: